Simplify br_if by removing its value operand.#709
Closed
sunfishcode wants to merge 1 commit intomasterfrom
Closed
Conversation
Member
|
I think this is a good option since
|
|
It's still not a great outcome as the 'arity' immediate is still there consuming space, just because a decision can not be made. Why not just propose to remove the 'arity' entirely, and if added in future then a separate opcode can just be added and we still have the more compact opcode for this high frequency case. Also the operator table has not been proposed yet, and there seems reasons to expect some objections particularly if it is a burden for a literal wasm interpreter. |
Member
|
Still catching up after vacation, but I think this is a good idea too. |
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposes removing br_if's value operand (effectively by fixing the arity to 0) to defer the question of how its return value should be handled. We'd have the flexibility to reintroduce this operand in the future.
This new PR is in place of reopening #681 which github won't let me re-open.