Closed
Conversation
LEBs are more space-efficient than uint32 for the very common case of br_table target entries being smaller than 4 bytes.
Member
|
lgtm |
1 similar comment
Member
|
lgtm |
Merged
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very significant portion of the AngryBots and BananaBread demo binaries is taken by
br_tableopcodes. In fact, in both of these binaries, the total space consumed bybr_tableis more thanbrandbr_ifcombined. This PR proposes using LEBs in the encoding ofbr_table. LEBs are more space-efficient than uint32 for the very common case of br_table target entries being smaller than 4 bytes, and they are more consistent with the rest of the format.A possible followup would be require the length of the entire
br_tableas an immediate as well, to allow for bytecode iterators to skip ahead without decoding the entire table.