Add signature-match check to JS.md to match Modules.md#744
Closed
lukewagner wants to merge 1 commit intomasterfrom
Closed
Add signature-match check to JS.md to match Modules.md#744lukewagner wants to merge 1 commit intomasterfrom
lukewagner wants to merge 1 commit intomasterfrom
Conversation
Member
Author
|
Hah, looks like I forgot and re-found this in #775. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modules.md#imports says that if an imported wasm function's signature doesn't match the import signature, an instantiation-time error is raised. This PR adds this check explicitly to the description of importing in JS.md.