Import attribute support#100
Closed
guybedford wants to merge 14 commits intomainfrom
Closed
Conversation
Collaborator
Author
|
Per discussion at #95 (comment) this is currently considered unnecessary for the initial implementation, closing to rather reopen when it comes up. In the mean time the tracking issue at #99 remains. |
guybedford
pushed a commit
that referenced
this pull request
Oct 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of implementing #99, the other part would need to be on the HTML integration side.
This just defines a new function "Validate and canonicalize the WebAssembly builtin attribute", which performs the canonicalizations listed in #99 to avoid duplicate module records.
In the HTML spec, it would then need to call into this canonicalization on the chosen attribute name (also a decision to be made in HTML), and then pass the corresponding string back into the the parse a WebAssembly module step.