Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Adds explanatory prose related to delegate.#246

Merged
Ms2ger merged 5 commits intoWebAssembly:mainfrom
ioannad:delegate-descriptions
Feb 23, 2023
Merged

Adds explanatory prose related to delegate.#246
Ms2ger merged 5 commits intoWebAssembly:mainfrom
ioannad:delegate-descriptions

Conversation

@ioannad
Copy link
Collaborator

@ioannad ioannad commented Dec 13, 2022

This resolves the last three so far unaddressed todo:: sections:

  • Add prose explaining try-delegate's jump.
  • Adds prose and intuition for delegating exception handlers.
    • Also a minor modification to the prose of catching exception handlers, that somewhat reduces calling the administrative instruction by its identifier (CAUGHTadm) in the prose.

This resolves the last three so far unaddressed `todo::` sections:
- Add prose explaining try-delegate's jump.
- Adds prose and intuition for delegating exception handlers.
  + Also a minor modification to the prose of catching exception handlers, that somewhat reduces calling the administrative instruction by its identifier (CAUGHTadm) in the prose.
@ioannad ioannad requested review from aheejin and rossberg and removed request for rossberg December 13, 2022 15:08
.. todo::
Add prose for delegating handlers.
Delegating handlers start with the identifier |DELEGATEadm| and carry a label index,
indicating the outer block in which any caught exceptions will be thrown (delegated to).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my email suggestion regarding a slight refactor of this syntax.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to change this prose here to match #226, but on second thought it doesn't make sense without the rest of the changed text. So I am reverting these changes and adding this missing prose to #226 instead.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

ioannad added a commit to ioannad/exception-handling that referenced this pull request Feb 15, 2023
as it doesn't make sense on its own in WebAssembly#246.
@takikawa takikawa self-requested a review February 22, 2023 22:16
@Ms2ger Ms2ger merged commit 0eb87db into WebAssembly:main Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants