This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Add initial tests and interpreter implementation#2
Merged
Conversation
sbc100
commented
Feb 17, 2021
sbc100
force-pushed
the
add_initial_spec_tests
branch
3 times, most recently
from
4cd186c to
a13eecb
Compare
sbc100
commented
Feb 17, 2021
sbc100
force-pushed
the
add_initial_spec_tests
branch
from
a13eecb to
ba995ae
Compare
sbc100
force-pushed
the
add_initial_spec_tests
branch
from
ba995ae to
b88d651
Compare
rossberg
reviewed
Feb 18, 2021
Comment on lines
+385
to
+386
| | Binary (Values.I32 I32Op.(Add | Sub | Mul)) -> true | ||
| | Binary (Values.I64 I64Op.(Add | Sub | Mul)) -> true |
Member
There was a problem hiding this comment.
Nit: the first -> true isn't needed here. ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.