This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Conversation
This was referenced Aug 9, 2021
Closed
Member
Author
|
@conrad-watt, friendly ping. |
Contributor
|
on this now, sorry |
conrad-watt
reviewed
Sep 17, 2021
| Instruction(None, r'\hex{D4}'), | ||
| Instruction(r'\REFASNONNULL', r'\hex{D3}', r'[(\REF~\NULL~\X{ht})] \to [(\REF~\X{ht})]', r'valid-ref.as_non_null', r'exec-ref.as_non_null'), | ||
| Instruction(r'\BRONNULL~l', r'\hex{D4}', r'[t^\ast~(\REF~\NULL~\X{ht})] \to [t^\ast~(\REF~\X{ht})]', r'valid-br_on_null', r'exec-br_on_null'), | ||
| Instruction(None, r'\hex{D5}'), |
Contributor
There was a problem hiding this comment.
Is there a reason br_on_null isn't next to br_on_non_null in the index space?
Member
Author
There was a problem hiding this comment.
D5 was already assigned to ref.eq at the time we added br_on_non_null.
| @@ -188,11 +189,13 @@ Instructions in this group are concerned with accessing :ref:`references <syntax | |||
| \production{instruction} & \instr &::=& | |||
| \dots \\&&|& | |||
| \REFNULL~\reftype \\&&|& | |||
Contributor
There was a problem hiding this comment.
\reftype here should be \heaptype - sorry if I missed this previously.
rossberg
commented
Sep 17, 2021
Member
Author
rossberg
left a comment
rossberg
left a comment
There was a problem hiding this comment.
Thanks for the review.
| Instruction(None, r'\hex{D4}'), | ||
| Instruction(r'\REFASNONNULL', r'\hex{D3}', r'[(\REF~\NULL~\X{ht})] \to [(\REF~\X{ht})]', r'valid-ref.as_non_null', r'exec-ref.as_non_null'), | ||
| Instruction(r'\BRONNULL~l', r'\hex{D4}', r'[t^\ast~(\REF~\NULL~\X{ht})] \to [t^\ast~(\REF~\X{ht})]', r'valid-br_on_null', r'exec-br_on_null'), | ||
| Instruction(None, r'\hex{D5}'), |
Member
Author
There was a problem hiding this comment.
D5 was already assigned to ref.eq at the time we added br_on_non_null.
| @@ -188,11 +189,13 @@ Instructions in this group are concerned with accessing :ref:`references <syntax | |||
| \production{instruction} & \instr &::=& | |||
| \dots \\&&|& | |||
| \REFNULL~\reftype \\&&|& | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the (non-controversial ones of the) new instructions to the spec.
This is the same as #50, but rebased on master.
@conrad-watt, PTAL. For some strange reason, GH doesn't let me add you as a reviewer this time.