This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Conversation
tlively
approved these changes
Jul 5, 2023
document/core/exec/instructions.rst
Outdated
|
|
||
| 6. Pop the :math:`n` values :math:`\val^\ast` from the stack. | ||
|
|
||
| 8. For every value :math:`\val_i` in :math:`\val^\ast`: |
document/core/exec/instructions.rst
Outdated
|
|
||
| 17. For each consecutive subsequence :math:`{b'}^n` of :math:`b^\ast`: | ||
|
|
||
| a. Let :math:`k_i` be the integer for which :math:`\bytes_{\X{ft}}(k_i)` is :math:`{b'}^n`. |
Member
There was a problem hiding this comment.
Does this work even if t is a floating point type?
Member
Author
There was a problem hiding this comment.
Changed to "constant"; also adjusted metavariable to c.
document/core/exec/instructions.rst
Outdated
|
|
||
| a. Trap. | ||
|
|
||
| 12. Let :math:`\fieldval` be the :ref:`field value <syntax-fieldval>` :math:`S.\SARRAYS[a].\AIFIELDS[i]`. |
Co-authored-by: Thomas Lively <tlively@google.com>
rossberg
commented
Jul 6, 2023
Member
Author
rossberg
left a comment
rossberg
left a comment
There was a problem hiding this comment.
Thanks for the thorough review!
document/core/exec/instructions.rst
Outdated
|
|
||
| 6. Pop the :math:`n` values :math:`\val^\ast` from the stack. | ||
|
|
||
| 8. For every value :math:`\val_i` in :math:`\val^\ast`: |
document/core/exec/instructions.rst
Outdated
|
|
||
| 17. For each consecutive subsequence :math:`{b'}^n` of :math:`b^\ast`: | ||
|
|
||
| a. Let :math:`k_i` be the integer for which :math:`\bytes_{\X{ft}}(k_i)` is :math:`{b'}^n`. |
Member
Author
There was a problem hiding this comment.
Changed to "constant"; also adjusted metavariable to c.
document/core/exec/instructions.rst
Outdated
|
|
||
| a. Trap. | ||
|
|
||
| 12. Let :math:`\fieldval` be the :ref:`field value <syntax-fieldval>` :math:`S.\SARRAYS[a].\AIFIELDS[i]`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving out type unrolling for now, since that's defined in #377.