This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Fix error in type of memory.init introduced in #56#57
Merged
Conversation
Sorry for the chrun. This time I'll double check the test in wabt before updating the testsuite repo.
Member
|
Should the size and offset fields of memory.init not be the same size as pointers, a la |
Member
Author
|
Those arguments are supposed to stay as i32.. at least according the overview and current implementations. |
Collaborator
|
I think it makes sense for these parameters to remain i32 since they are determined by the data segment, which still doesn't use 64-bit indices. (Nor should it, probably.) |
Member
|
Ah, right. I guess that logic would make more sense for memory.copy than memory.init. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the churn. This time I'll double check the test in wabt before updating the testsuite repo.