This repository was archived by the owner on Nov 3, 2021. It is now read-only.
table.fill: Bounds check before mutating the table#106
Merged
rossberg merged 1 commit intoWebAssembly:masterfrom Jul 21, 2020
Merged
table.fill: Bounds check before mutating the table#106rossberg merged 1 commit intoWebAssembly:masterfrom
rossberg merged 1 commit intoWebAssembly:masterfrom
Conversation
binji
reviewed
Jul 14, 2020
| 19. Execute the instruction :math:`\TABLEFILL~x`. | ||
|
|
||
| .. math:: | ||
| \begin{array}{l} |
Member
There was a problem hiding this comment.
The formal notation needs to be fixed too -- this will still partially fill.
Contributor
Author
There was a problem hiding this comment.
Perhaps someone else could fix that part? I'm not super familiar with latex / our conventions for the formal notation.
Member
|
Thanks for looking into this. The corresponding formal rules should look something like this: |
Fixes WebAssembly#105 Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
150ee7b to
465b37d
Compare
Contributor
Author
Thanks! I've added that to the commit. |
rossberg
approved these changes
Jul 21, 2020
Contributor
Author
|
(Note: I don't have merge permissions myself) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105
@rossberg please take a look. Thanks!