This repository was archived by the owner on Nov 3, 2021. It is now read-only.
[interpreter] Implement basic reference types and multiple tables #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Mar 5, 2018
| module: ( module <name>? <typedef>* <func>* <import>* <export>* <table>? <memory>? <global>* <elem>* <data>* <start>? ) | ||
| <typedef>* <func>* <import>* <export>* <table>? <memory>? <global>* <elem>* <data>* <start>? ;; = | ||
| ( module <typedef>* <func>* <import>* <export>* <table>? <memory>? <global>* <elem>* <data>* <start>? ) | ||
| module: ( module <name>? <typedef>* <func>* <import>* <export>* <table>* <memory>? <global>* <elem>* <data>* <start>? ) |
There was a problem hiding this comment.
Does elem_type need to change in this file as well to support eqref and anyref in addition to anyfunc?
There was a problem hiding this comment.
Also, val_type I suppose (or rather, split it and change what param, result, local, etc can handle to include refs)
Member
Author
There was a problem hiding this comment.
Oops, you're right. Fixed.
lukewagner
approved these changes
Mar 19, 2018
Member
lukewagner
left a comment
lukewagner
left a comment
There was a problem hiding this comment.
Ok, well, modulo the one null type issue, everything lgtm; happy to discuss null type at April CG meeting.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First go at implementing the baseline proposal:
anyrefandeqref(and internalnullref) and respective subtypingref.null,ref.isnull,ref.eq,get_table,set_tableref.nullandref Nliterals in assertion languageOpcode allocation should be considered preliminary.