This repository was archived by the owner on Dec 22, 2021. It is now read-only.
[test] Add more literal tests for min/max/abs ops#154
Merged
tlively merged 2 commits intoWebAssembly:masterfrom Dec 12, 2019
Merged
[test] Add more literal tests for min/max/abs ops#154tlively merged 2 commits intoWebAssembly:masterfrom
tlively merged 2 commits intoWebAssembly:masterfrom
Conversation
This PR covers tests for some float literal introduced in WebAssembly/spec#1069 These tests are pulled from WAVM/WAVM#234
Contributor
Author
tlively
reviewed
Dec 11, 2019
test/core/simd/meta/simd_float_op.py
Outdated
| return '-0x0p+0' | ||
| result = min(f1, f2) | ||
| if hex_form: | ||
| result = min(f1, f2) |
Member
There was a problem hiding this comment.
This logic would be easier to follow if this was simply return min(f1, f2).hex(). Same below.
tlively
approved these changes
Dec 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers tests for some float literal introduced in WebAssembly/spec#1069, specific for following ops:
f32x4.abs
f32x4.min
f32x4.max
f64x2.abs
f64x2.min
f64x2.max
These tests are pulled from WAVM/WAVM#234.