Skip to content
This repository was archived by the owner on Dec 22, 2021. It is now read-only.

Fix some stale references to value types#527

Merged
ngzhian merged 3 commits intoWebAssembly:mainfrom
ngzhian:fix-comments-from-merge-pr
Nov 11, 2021
Merged

Fix some stale references to value types#527
ngzhian merged 3 commits intoWebAssembly:mainfrom
ngzhian:fix-comments-from-merge-pr

Conversation

@ngzhian
Copy link
Member

@ngzhian ngzhian commented Nov 10, 2021

Based on comments from WebAssembly/spec#1391.

Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@ngzhian
Copy link
Member Author

ngzhian commented Nov 11, 2021

Not sure why build-core-spec is failing, it seems to be using the wrong katex version. Will investigate.

@ngzhian
Copy link
Member Author

ngzhian commented Nov 11, 2021

@ngzhian
Copy link
Member Author

ngzhian commented Nov 11, 2021

the submodule checkout isn't working right:

https://github.com/WebAssembly/simd/runs/4181145280?check_suite_focus=true#step:2:465

My dumb mistake, I added some katex changes unintentionally.

@ngzhian ngzhian merged commit eda5421 into WebAssembly:main Nov 11, 2021
@ngzhian ngzhian deleted the fix-comments-from-merge-pr branch November 11, 2021 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants