Left-to-right test#119
Left-to-right test#119sunfishcode merged 2 commits intoWebAssembly:masterfrom pjuftring:left-to-right
Conversation
This test is from TestingTodo. It tests, if all arithmetic instructions evaluate their operands from left to right.
ml-proto/test/left-to-right.wast
Outdated
There was a problem hiding this comment.
For consistency with the overall style of the tests in this directory, please put spaces between operands.
|
Other than one comment above, lgtm. Implementing tests in TestingTodo.md is great! Submitting test cases either individually or in groups is fine with me. FYI, I'm also writing some tests -- #113 -- so if there are specific things you're interested in working on, let me know and we can coordinate and avoid duplicating effort. |
For consistency with the other tests, I added missing spaces between operands.
|
lgtm; thanks! |
|
@sunfishcode You said, I should let you know on which tests I'm working at the moment. So here is a list of tests I'm interested in/working on:
|
|
Great! I've now created #132 to serve as a central place for discussing writing tests for the remainder of TestingTodo.md going forward. |
Fix a couple of parser omissions regarding elem & data syntax. Refactor grammar in spec slightly for more clarity. Adjust tests.
This command is meant to execute each action on a separate thread, then validate that each returns the expected value. It's currently unimplemented in both `script/run.ml` and `script/js.ml`.
Fix names of dot instructions
This tests, if all arithmetic instructions evaluate their operands from left to right.
At the moment, I try to implement as many tests mentioned in TestingTodo.md as I can. I hope, that's ok :)
Should I make a pull request for each test, or wait until I have a bunch of tests and make a Pull Request for all of them together?