Conversation
gumb0
pushed a commit
to wasmx/wasm-spec
that referenced
this pull request
Sep 21, 2020
Fixes WebAssembly#1224 Add testing for other values that seem too big to be converted, but are ok after rounding. This is the only one that was a spec interpreter bug. I wrote those tests in a simple way with .9 values, replacing the .9999999 from earlier - as @binji said, we should either use hex-float notation, or avoid testing the parser at the same time. As the issue here is rounding, I think it's clearest to add .9 which suggests "this should be rounded away".
kateinoigakukun
added a commit
to kateinoigakukun/wasminspect
that referenced
this pull request
Nov 3, 2021
raoxiaojia
pushed a commit
to WasmCert/spec
that referenced
this pull request
Apr 29, 2025
Fixes WebAssembly#1224 Add testing for other values that seem too big to be converted, but are ok after rounding. This is the only one that was a spec interpreter bug. I wrote those tests in a simple way with .9 values, replacing the .9999999 from earlier - as @binji said, we should either use hex-float notation, or avoid testing the parser at the same time. As the issue here is rounding, I think it's clearest to add .9 which suggests "this should be rounded away".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1224
Add testing for other values that seem too big to be
converted, but are ok after rounding. This is the only
one that was a spec interpreter bug. I wrote those
tests in a simple way with
.9values, replacingthe
.9999999from earlier - as @binji said, we shouldeither use hex-float notation, or avoid testing the parser
at the same time. As the issue here is rounding, I think
it's clearest to add
.9which suggests "this should berounded away".
(This is my first time writing OCaml so I'm sure I've
messed it up...)