[test] Add tests for functions sharing same implementation#1289
Merged
rossberg merged 1 commit intoWebAssembly:masterfrom Mar 4, 2021
Merged
[test] Add tests for functions sharing same implementation#1289rossberg merged 1 commit intoWebAssembly:masterfrom
rossberg merged 1 commit intoWebAssembly:masterfrom
Conversation
Contributor
Author
|
I've requested access to the WebAssembly Community Group. |
atdrendel
changed the title
rossberg
approved these changes
Feb 23, 2021
Contributor
Author
|
@rossberg My request to join the W3C WebAssembly group has been approved. Please let me know if there is anything you want me to change in this pull request before merging it. |
gumb0
pushed a commit
to wasmx/wasm-spec
that referenced
this pull request
Mar 4, 2021
gumb0
pushed a commit
to wasmx/wasm-spec
that referenced
this pull request
Jun 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a test to verify WebAssembly interpreters correctly handle the case where multiple exported functions share a single implementation. I've run into this problem when trying to use Libsodium with some Wasm interpreters. Libsodium exposes a number of different functions that wrap private constants, some of which are equal. These functions are all compiled down into the same WebAssembly function implementation with different exported names.