Add global_i64 to js harness#1290
Merged
Ms2ger merged 2 commits intoWebAssembly:masterfrom Mar 2, 2021
Merged
Conversation
PR WebAssembly#1288 is the first use of global_i64, but the generated JS did not yet define this global, which causes the JS test to fail to link.
Collaborator
|
Doesn't this need to be a bigint? |
Member
Author
|
Good point, fixed, thanks! |
Ms2ger
approved these changes
Mar 2, 2021
Collaborator
Ms2ger
left a comment
Ms2ger
left a comment
There was a problem hiding this comment.
Verified locally. Thanks.
raoxiaojia
pushed a commit
to WasmCert/spec
that referenced
this pull request
Apr 29, 2025
PR WebAssembly#1288 is the first use of global_i64, but the generated JS did not yet define this global, which causes the JS test to fail to link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1288 is the first use of global_i64, but the generated JS did not
yet define this global, which causes the JS test to fail to link.