[test] Test cases with imports the same name as exports#1291
Merged
rossberg merged 1 commit intoWebAssembly:masterfrom Mar 2, 2021
Merged
[test] Test cases with imports the same name as exports#1291rossberg merged 1 commit intoWebAssembly:masterfrom
rossberg merged 1 commit intoWebAssembly:masterfrom
Conversation
rossberg
approved these changes
Mar 2, 2021
Contributor
Author
|
Thanks! |
gumb0
pushed a commit
to wasmx/wasm-spec
that referenced
this pull request
Mar 4, 2021
gumb0
pushed a commit
to wasmx/wasm-spec
that referenced
this pull request
Jun 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While integrating wasm3 into fizzy's benchmarking suite, we found some issues with wasm3. Namely it did not make a distinction between imported and exported functions where the name matches. Since wasm3 passes the spec tests, I think such cases are not covered. The original test case can be seen at wasm3/wasm3#143.