Conversation
conrad-watt
left a comment
conrad-watt
left a comment
There was a problem hiding this comment.
Changes LGTM
some other references to "bit width" should be changed from syntax-valtype to syntax-numtype
one mention here (memory instructions):
https://webassembly.github.io/spec/core/syntax/instructions.html?highlight=bit%20width#memory-instructions
two mentions here (load and store)
https://webassembly.github.io/spec/core/exec/instructions.html?highlight=bit%20width#memory-instructions
document/core/binary/types.rst
Outdated
| In future versions of WebAssembly, value types may include types denoted by :ref:`type indices <syntax-typeidx>`. | ||
| Thus, the binary format for types corresponds to the encodings of small negative :math:`\xref{binary/values}{binary-sint}{\sN}` values, so that they can coexist with (positive) type indices in the future. | ||
| In some places, possible types include both type constructors or types denoted by :ref:`type indices <syntax-typeidx>`. | ||
| Thus, the binary format for most type constructors corresponds to the encodings of small negative :math:`\xref{binary/values}{binary-sint}{\sN}` values, such that they can unambiguously occur in the same place as (positive) type indices. |
There was a problem hiding this comment.
"most type constructors" - is it possible for a type constructor to be represented by something other than a negative number?
There was a problem hiding this comment.
Indeed not, removed "most".
rossberg
left a comment
rossberg
left a comment
There was a problem hiding this comment.
Ah, thanks. Fixed, plus a couple more places where it should now be numtype. PTAL.
document/core/binary/types.rst
Outdated
| In future versions of WebAssembly, value types may include types denoted by :ref:`type indices <syntax-typeidx>`. | ||
| Thus, the binary format for types corresponds to the encodings of small negative :math:`\xref{binary/values}{binary-sint}{\sN}` values, so that they can coexist with (positive) type indices in the future. | ||
| In some places, possible types include both type constructors or types denoted by :ref:`type indices <syntax-typeidx>`. | ||
| Thus, the binary format for most type constructors corresponds to the encodings of small negative :math:`\xref{binary/values}{binary-sint}{\sN}` values, such that they can unambiguously occur in the same place as (positive) type indices. |
There was a problem hiding this comment.
Indeed not, removed "most".
2 participants
Discovered while working on WebAssembly/function-references#49.