Add support for "foreach" and "define" to masm#157
Closed
pjuftring wants to merge 2 commits intoWebAssembly:masmfrom
Closed
Add support for "foreach" and "define" to masm#157pjuftring wants to merge 2 commits intoWebAssembly:masmfrom
pjuftring wants to merge 2 commits intoWebAssembly:masmfrom
Conversation
pjuftring
changed the title
Member
|
I think the idea of a foreach macro makes sense. I'll take a closer look at this once we know what's happening with #155. |
Contributor
Author
|
Closing this PR since #155 is closed, too. |
rossberg
added a commit
that referenced
this pull request
Feb 11, 2021
ngzhian
pushed a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
This was suggested here: WebAssembly/exception-handling#131 (comment) Closes WebAssembly#131.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an implementation for "foreach" and "define" as announced in #155 (Still not sure, if this is the right way to contribute to open PRs)
It works great, the only problem I encountered is, that in some cases (e.g. nesting) artifacts from comments mess up the generated code, but apart from that, everything works as intended.