Merged
Conversation
Removes every trace of existence of page_size from the source, the testfiles and README.md WebAssembly/design#442
ml-proto/host/params.ml
Outdated
Member
There was a problem hiding this comment.
Given that this is no longer a parameter, can you instead remove this definition completely? It should also vanish from the host_params type in the eval module.
Member
|
Keeping page_size as a named variable improves the "specyness" of the code, and makes it easier to find all the places in the spec that case about page sizes. I would prefer to leave it in. |
Member
|
Fair enough. The only remaining occurrence is in the evaluation of GrowMemory. I suggest exporting page_size as a constant from the memory module and using that there. |
…emove_page-size Conflicts: ml-proto/host/lexer.mll ml-proto/host/parser.mly
To keep things more "speccy", page_size is added to the memory module and is used by the GrowMemory instruction.
…emove_page-size Conflicts: ml-proto/host/lexer.mll ml-proto/host/parser.mly
Member
|
lgtm |
Member
|
LGTM |
Connicpu
pushed a commit
to Connicpu/wasm-spec
that referenced
this pull request
May 11, 2020
ngzhian
pushed a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
Uncomment test code
alexcrichton
pushed a commit
to WebAssembly/wide-arithmetic
that referenced
this pull request
Sep 19, 2025
Support and test empty list syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes every trace of existence of page_size from the source, the
testfiles and README.md
WebAssembly/design#442