[spec] Normative: Permit work in parallel during instantiation#1606
Merged
Ms2ger merged 3 commits intoWebAssembly:mainfrom Feb 21, 2023
Merged
[spec] Normative: Permit work in parallel during instantiation#1606Ms2ger merged 3 commits intoWebAssembly:mainfrom
Ms2ger merged 3 commits intoWebAssembly:mainfrom
Conversation
Ms2ger
approved these changes
Feb 20, 2023
Collaborator
Ms2ger
left a comment
Ms2ger
left a comment
There was a problem hiding this comment.
Doh, thanks for pointing that out.
JSC will have to do asynchronous compilation work during some instantiations. To be consistent, this PR always queues a task to complete instantiation, except through the synchronous Instance(module) API, to ensure consistency across platforms. This patch also cleans up the specification in various surrounding ways: - Include notes about APIs whose use is discouraged/may be limited Closes WebAssembly#741 See also webpack/webpack#6433
Ms2ger
force-pushed
the
littledan-queueing
branch
from
699ce94 to
b68d53e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a recreation of @littledan’s #745, which was erroneously merged into
masterinstead ofmainbecause it’s five years old.