Skip to content

[test] Remove malformed tests that become valid with memory64 #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rossberg merged 2 commits into from
May 10, 2023
Merged

[test] Remove malformed tests that become valid with memory64 #1648

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0294670
[test] Remove malformed tests that become valid with memory64
backes May 4, 2023
a6136e4
Add back tests, but commented out with a TODO
backes May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
237 changes: 122 additions & 115 deletions test/core/binary.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,25 +492,27 @@
)
"integer representation too long"
)
(assert_malformed
(module binary
"\00asm" "\01\00\00\00"
"\01\04\01\60\00\00" ;; Type section
"\03\02\01\00" ;; Function section
"\05\03\01\00\01" ;; Memory section
"\0a\11\01" ;; Code section
;; function 0
"\0f\01\01" ;; local type count
"\7f" ;; i32
"\41\00" ;; i32.const 0
"\28" ;; i32.load
"\02" ;; alignment 2
"\82\80\80\80\80\00" ;; offset 2 with one byte too many
"\1a" ;; drop
"\0b" ;; end
)
"integer representation too long"
)
;; The memory offset will be decoded as u64 in the memory64 proposal.
;; TODO: Re-enable this test as assert_trap test in the memory64 repo.
;; (assert_malformed
;; (module binary
;; "\00asm" "\01\00\00\00"
;; "\01\04\01\60\00\00" ;; Type section
;; "\03\02\01\00" ;; Function section
;; "\05\03\01\00\01" ;; Memory section
;; "\0a\11\01" ;; Code section
;; ;; function 0
;; "\0f\01\01" ;; local type count
;; "\7f" ;; i32
;; "\41\00" ;; i32.const 0
;; "\28" ;; i32.load
;; "\02" ;; alignment 2
;; "\82\80\80\80\80\00" ;; offset 2 with one byte too many
;; "\1a" ;; drop
;; "\0b" ;; end
;; )
;; "integer representation too long"
;; )
(assert_malformed
(module binary
"\00asm" "\01\00\00\00"
Expand Down Expand Up @@ -549,25 +551,27 @@
)
"integer representation too long"
)
(assert_malformed
(module binary
"\00asm" "\01\00\00\00"
"\01\04\01\60\00\00" ;; Type section
"\03\02\01\00" ;; Function section
"\05\03\01\00\01" ;; Memory section
"\0a\12\01" ;; Code section
;; function 0
"\10\01\01" ;; local type count
"\7f" ;; i32
"\41\00" ;; i32.const 0
"\41\03" ;; i32.const 3
"\36" ;; i32.store
"\02" ;; alignment 2
"\82\80\80\80\80\00" ;; offset 2 with one byte too many
"\0b" ;; end
)
"integer representation too long"
)
;; The memory offset will be decoded as u64 in the memory64 proposal.
;; TODO: Re-enable this test as assert_trap test in the memory64 repo.
;; (assert_malformed
;; (module binary
;; "\00asm" "\01\00\00\00"
;; "\01\04\01\60\00\00" ;; Type section
;; "\03\02\01\00" ;; Function section
;; "\05\03\01\00\01" ;; Memory section
;; "\0a\12\01" ;; Code section
;; ;; function 0
;; "\10\01\01" ;; local type count
;; "\7f" ;; i32
;; "\41\00" ;; i32.const 0
;; "\41\03" ;; i32.const 3
;; "\36" ;; i32.store
;; "\02" ;; alignment 2
;; "\82\80\80\80\80\00" ;; offset 2 with one byte too many
;; "\0b" ;; end
;; )
;; "integer representation too long"
;; )

;; Signed LEB128 must not be overlong
(assert_malformed
Expand Down Expand Up @@ -629,44 +633,46 @@
)
"integer too large"
)
(assert_malformed
(module binary
"\00asm" "\01\00\00\00"
"\01\04\01\60\00\00" ;; Type section
"\03\02\01\00" ;; Function section
"\05\03\01\00\01" ;; Memory section
"\0a\10\01" ;; Code section
;; function 0
"\0e\01\01" ;; local type count
"\7f" ;; i32
"\41\00" ;; i32.const 0
"\28" ;; i32.load
"\02" ;; alignment 2
"\82\80\80\80\10" ;; offset 2 with unused bits set
"\1a" ;; drop
"\0b" ;; end
)
"integer too large"
)
(assert_malformed
(module binary
"\00asm" "\01\00\00\00"
"\01\04\01\60\00\00" ;; Type section
"\03\02\01\00" ;; Function section
"\05\03\01\00\01" ;; Memory section
"\0a\10\01" ;; Code section
;; function 0
"\0e\01\01" ;; local type count
"\7f" ;; i32
"\41\00" ;; i32.const 0
"\28" ;; i32.load
"\02" ;; alignment 2
"\82\80\80\80\40" ;; offset 2 with some unused bits set
"\1a" ;; drop
"\0b" ;; end
)
"integer too large"
)
;; The memory offset will be decoded as u64 in the memory64 proposal.
;; TODO: Re-enable this test as assert_trap test in the memory64 repo.
;; (assert_malformed
;; (module binary
;; "\00asm" "\01\00\00\00"
;; "\01\04\01\60\00\00" ;; Type section
;; "\03\02\01\00" ;; Function section
;; "\05\03\01\00\01" ;; Memory section
;; "\0a\10\01" ;; Code section
;; ;; function 0
;; "\0e\01\01" ;; local type count
;; "\7f" ;; i32
;; "\41\00" ;; i32.const 0
;; "\28" ;; i32.load
;; "\02" ;; alignment 2
;; "\82\80\80\80\10" ;; offset 2 with unused bits set
;; "\1a" ;; drop
;; "\0b" ;; end
;; )
;; "integer too large"
;; )
;; (assert_malformed
;; (module binary
;; "\00asm" "\01\00\00\00"
;; "\01\04\01\60\00\00" ;; Type section
;; "\03\02\01\00" ;; Function section
;; "\05\03\01\00\01" ;; Memory section
;; "\0a\10\01" ;; Code section
;; ;; function 0
;; "\0e\01\01" ;; local type count
;; "\7f" ;; i32
;; "\41\00" ;; i32.const 0
;; "\28" ;; i32.load
;; "\02" ;; alignment 2
;; "\82\80\80\80\40" ;; offset 2 with some unused bits set
;; "\1a" ;; drop
;; "\0b" ;; end
;; )
;; "integer too large"
;; )
(assert_malformed
(module binary
"\00asm" "\01\00\00\00"
Expand Down Expand Up @@ -742,45 +748,46 @@
)
"integer too large"
)
(assert_malformed
(module binary
"\00asm" "\01\00\00\00"
"\01\04\01\60\00\00" ;; Type section
"\03\02\01\00" ;; Function section
"\05\03\01\00\01" ;; Memory section
"\0a\11\01" ;; Code section
;; function 0
"\0f\01\01" ;; local type count
"\7f" ;; i32
"\41\00" ;; i32.const 0
"\41\03" ;; i32.const 3
"\36" ;; i32.store
"\02" ;; alignment 2
"\82\80\80\80\10" ;; offset 2 with unused bits set
"\0b" ;; end
)
"integer too large"
)
(assert_malformed
(module binary
"\00asm" "\01\00\00\00"
"\01\04\01\60\00\00" ;; Type section
"\03\02\01\00" ;; Function section
"\05\03\01\00\01" ;; Memory section
"\0a\11\01" ;; Code section

;; function 0
"\0f\01\01" ;; local type count
"\7f" ;; i32
"\41\00" ;; i32.const 0
"\41\03" ;; i32.const 3
"\36" ;; i32.store
"\02" ;; alignment 2
"\82\80\80\80\40" ;; offset 2 with some unused bits set
"\0b" ;; end
)
"integer too large"
)
;; The memory offset will be decoded as u64 in the memory64 proposal.
;; TODO: Re-enable this test as assert_trap test in the memory64 repo.
;; (assert_malformed
;; (module binary
;; "\00asm" "\01\00\00\00"
;; "\01\04\01\60\00\00" ;; Type section
;; "\03\02\01\00" ;; Function section
;; "\05\03\01\00\01" ;; Memory section
;; "\0a\11\01" ;; Code section
;; ;; function 0
;; "\0f\01\01" ;; local type count
;; "\7f" ;; i32
;; "\41\00" ;; i32.const 0
;; "\41\03" ;; i32.const 3
;; "\36" ;; i32.store
;; "\02" ;; alignment 2
;; "\82\80\80\80\10" ;; offset 2 with unused bits set
;; "\0b" ;; end
;; )
;; "integer too large"
;; )
;; (assert_malformed
;; (module binary
;; "\00asm" "\01\00\00\00"
;; "\01\04\01\60\00\00" ;; Type section
;; "\03\02\01\00" ;; Function section
;; "\05\03\01\00\01" ;; Memory section
;; "\0a\11\01" ;; Code section
;; ;; function 0
;; "\0f\01\01" ;; local type count
;; "\7f" ;; i32
;; "\41\00" ;; i32.const 0
;; "\41\03" ;; i32.const 3
;; "\36" ;; i32.store
;; "\02" ;; alignment 2
;; "\82\80\80\80\40" ;; offset 2 with some unused bits set
;; "\0b" ;; end
;; )
;; "integer too large"
;; )

;; Signed LEB128s sign-extend
(assert_malformed
Expand Down