[test] text format: drop support for some pre-standard keywords#1680
Merged
rossberg merged 2 commits intoWebAssembly:mainfrom Sep 20, 2023
Merged
[test] text format: drop support for some pre-standard keywords#1680rossberg merged 2 commits intoWebAssembly:mainfrom
rossberg merged 2 commits intoWebAssembly:mainfrom
Conversation
rossberg
approved these changes
Sep 20, 2023
Member
rossberg
left a comment
rossberg
left a comment
There was a problem hiding this comment.
LGTM, except nit: can we rename the test to obsolete-keywords?
Member
Author
Sure, pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 2018 (#720 and #926), the spec renamed some keywords before WebAssembly was standardized (
get_local->local.get,anyfunc->funcref, etc.).WABT dropped support for the old names in 2021 (WebAssembly/wabt#1792), MDN revised its documentation in 2022 (mdn/interactive-examples#2298), and wasm-tools dropped support last month (bytecodealliance/wasm-tools#1184). However, users do get confused when they find a tutorial that uses the old syntax and the code works in more-tolerant implementations but is rejected by other conforming consumers. (E.g. WebAssembly/wabt#1802, WebAssembly/wabt#1820, WebAssembly/wabt#1883, WebAssembly/wabt#2010, ...)
Now that it's been five years and tutorials using the old syntax are increasingly rare, this PR would check that the old keywords are now considered malformed.