Do not accept a too-large offset in memory accesses#172
Merged
sunfishcode merged 1 commit intomasterfrom Nov 11, 2015
Merged
Conversation
ml-proto/spec/check.ml
Outdated
Member
There was a problem hiding this comment.
This constant could use hex form to make it more obvious what value it is: 0xffffffffL.
Member
|
lgtm, with minor nit above. |
kripken
force-pushed
the
fix-address.wast
branch
from
2ea50e2 to
82f57fe
Compare
Member
|
LGTM |
sunfishcode
added a commit
that referenced
this pull request
Nov 11, 2015
Do not accept a too-large offset in memory accesses
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
Change Rep type of SIMD to be immutable string
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They should be a uint32 value.
This fixes #161.