[test] Add negative test for invalid section ordering#1775
Merged
rossberg merged 1 commit intoWebAssembly:mainfrom Aug 12, 2024
dzfrias:section-order
Merged
[test] Add negative test for invalid section ordering#1775rossberg merged 1 commit intoWebAssembly:mainfrom dzfrias:section-order
rossberg merged 1 commit intoWebAssembly:mainfrom
dzfrias:section-order
Conversation
rossberg
reviewed
Aug 8, 2024
Member
rossberg
left a comment
rossberg
left a comment
There was a problem hiding this comment.
Thanks, definitely good to test this! Can I motivate you to add versions for other section pairs as well? It should be enough to test consecutive pairs.
Contributor
Author
|
Ok, I added tests for all of the consecutive section pairs! |
dzfrias
added a commit
to dzfrias/ladybird
that referenced
this pull request
Aug 10, 2024
There are (currently) no spec-tests ensuring that section ordering is enforced, but it _is_ a part of the spec. A pull request to add this to the specification testsuite has been opened at WebAssembly/spec#1775.
dzfrias
added a commit
to dzfrias/ladybird
that referenced
this pull request
Aug 10, 2024
There are (currently) no spec-tests ensuring that section ordering is enforced, but it _is_ a part of the spec. A pull request to add this to the specification testsuite has been opened at WebAssembly/spec#1775.
awesomekling
pushed a commit
to LadybirdBrowser/ladybird
that referenced
this pull request
Aug 10, 2024
There are (currently) no spec-tests ensuring that section ordering is enforced, but it _is_ a part of the spec. A pull request to add this to the specification testsuite has been opened at WebAssembly/spec#1775.
rossberg
approved these changes
Aug 12, 2024
Member
rossberg
left a comment
rossberg
left a comment
There was a problem hiding this comment.
Thanks!
(FYI, please never force-push to branches under review, since that breaks GH's review work-flow. Didn't matter much for this small PR, but would for more complex ones.)
Contributor
Author
|
Ok, good to know for next time! |
nico
pushed a commit
to nico/serenity
that referenced
this pull request
Nov 9, 2024
There are (currently) no spec-tests ensuring that section ordering is enforced, but it _is_ a part of the spec. A pull request to add this to the specification testsuite has been opened at WebAssembly/spec#1775. (cherry picked from commit c586653)
nico
pushed a commit
to nico/serenity
that referenced
this pull request
Nov 9, 2024
There are (currently) no spec-tests ensuring that section ordering is enforced, but it _is_ a part of the spec. A pull request to add this to the specification testsuite has been opened at WebAssembly/spec#1775. (cherry picked from commit c586653)
nico
pushed a commit
to nico/serenity
that referenced
this pull request
Nov 9, 2024
There are (currently) no spec-tests ensuring that section ordering is enforced, but it _is_ a part of the spec. A pull request to add this to the specification testsuite has been opened at WebAssembly/spec#1775. (cherry picked from commit c586653)
nico
pushed a commit
to nico/serenity
that referenced
this pull request
Nov 10, 2024
There are (currently) no spec-tests ensuring that section ordering is enforced, but it _is_ a part of the spec. A pull request to add this to the specification testsuite has been opened at WebAssembly/spec#1775. (cherry picked from commit c586653)
nico
pushed a commit
to nico/serenity
that referenced
this pull request
Nov 10, 2024
There are (currently) no spec-tests ensuring that section ordering is enforced, but it _is_ a part of the spec. A pull request to add this to the specification testsuite has been opened at WebAssembly/spec#1775. (cherry picked from commit c586653)
nico
pushed a commit
to SerenityOS/serenity
that referenced
this pull request
Nov 10, 2024
There are (currently) no spec-tests ensuring that section ordering is enforced, but it _is_ a part of the spec. A pull request to add this to the specification testsuite has been opened at WebAssembly/spec#1775. (cherry picked from commit c586653)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I know, there are no tests that suggest the correct order of sections. Binary modules with out-of-order sections are not failing in the Ladybird WebAssembly implementation, LibWasm.