[js-api] Throw in toResizableBuffer if memory has no max#1871
Closed
syg wants to merge 1 commit intoWebAssembly:mainfrom
Closed
[js-api] Throw in toResizableBuffer if memory has no max#1871syg wants to merge 1 commit intoWebAssembly:mainfrom
syg wants to merge 1 commit intoWebAssembly:mainfrom
Conversation
Contributor
Author
|
This change got consensus in the April 22, 2025 CG meeting. |
Contributor
Author
|
@conrad-watt PTAL. I can't tag reviewers for some reason. |
Member
|
@conrad-watt, can you please review this? |
eqrion
approved these changes
Sep 15, 2025
Collaborator
eqrion
left a comment
eqrion
left a comment
There was a problem hiding this comment.
This matches what we agreed upon.
Collaborator
|
Should this be merged into main or 3.0? |
|
This PR appears to have been superseded by #1961. |
Collaborator
|
Yeah, I think this can be closed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion in #1292 (comment)