[test] align.wast: add tests of malformed memop flags in wasm-3.0#1886
Merged
rossberg merged 1 commit intoWebAssembly:wasm-3.0from Mar 27, 2025
Merged
[test] align.wast: add tests of malformed memop flags in wasm-3.0#1886rossberg merged 1 commit intoWebAssembly:wasm-3.0from
rossberg merged 1 commit intoWebAssembly:wasm-3.0from
Conversation
rossberg
approved these changes
Mar 27, 2025
Member
rossberg
left a comment
rossberg
left a comment
There was a problem hiding this comment.
LGTM (not sure align.wast is the ideal place, but I'm fine with that)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests for malformed binary-format memop flags to the wasm-3.0 tests.
The main-branch
align.wasthas malformed tests (added in #1751), but multi-memory liberalizes the encoding so the existing tests were changed toassert_invalidin multi-memory and wasm-3.0. This adds back some (more-extreme) examples of malformed flags.