Separate out remaining memory 64 tests into proposal directory#1978
Separate out remaining memory 64 tests into proposal directory#1978dschuff merged 2 commits intoWebAssembly:mainfrom
Conversation
| @@ -0,0 +1,33 @@ | |||
| (module binary | |||
There was a problem hiding this comment.
Small nit, maybe rename this file binary-leb128-16.wast or something for readability? Or maybe use underscores; we really aren't consistent about that but it seems most files at least in memory64 use underscores.
There was a problem hiding this comment.
I did wonder about this and chose not to put a separator because I wasn't sure which was correct, I've renamed it in 6a0cf32 to what I imagine it would look like if we standardised everything to use underscores
There was a problem hiding this comment.
We could also change the original to match?
There was a problem hiding this comment.
Yeah, you could probably go either way. Let's go with this for now and if someone else wants to offer an opinion we can talk about it.
I wouldn't necessarily mind changing the original either, but let's make that a separate PR. That way we won't block this change (which actually has some practical value) with one that's just renaming.
|
thanks! |
2 participants
Just following on from @dschuff's work which separates memory64 proposal tests from the main body., this came off the back of conversation in the following issue