Reorder select's operands to put the condition last.#221
Merged
sunfishcode merged 1 commit intomasterfrom Feb 4, 2016
Merged
Conversation
ml-proto/spec/eval.ml
Outdated
Member
There was a problem hiding this comment.
It seems you also need to move this line after the other calls.
This implements the select portion of WebAssembly/design#489 br_if operands are more involved, so I'll submit a separate PR for them.
sunfishcode
force-pushed
the
select-operand-order
branch
from
43c87e3 to
5ad2a0e
Compare
Member
Author
|
Fixed the evaluation order now that 76553cf has landed which has the test for operand evaluation order. |
Member
|
lgtm |
sunfishcode
added a commit
that referenced
this pull request
Feb 4, 2016
Reorder select's operands to put the condition last.
jfbastien
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Feb 5, 2016
The ordering changed in: WebAssembly/spec#221 Which changed the spec tests, breaking sexpr-wasm because it pulls in the spec tests. This was then fixed: WebAssembly/wabt@23dc368 Which in turn breaks when binaryen feeds sexpr-wasm .wast files with the old select operand ordering. Note that this PR has new failures when running the torture tests in binaryen-shell: the order of evaluation is correct in binaryen-shell but isn't emitted properly by LLVM in the .s files. This will require another patch to fix LLVM.
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
* Formal overview: add uncaught exceptions Based on this previous discussion: https://github.com/WebAssembly/exception-handling/pull/143/files#r761207853 Also: - fixed throw contexts to include situations where `val* T instr*` in general. * Addressed review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the select portion of
WebAssembly/design#489
br_if operands are more involved, so I'll submit a separate PR for them.