Merged
Conversation
Member
|
Another approach would be to make alignment non-optional, and then optimize the binary encoding using the idea of including immediate values in the opcode table. That way we wouldn't need any sentinel values. What do you think? |
Member
Author
|
Oh right, that's even simpler and all of the encoding schemes we're talking about shouldn't benefit from having |
lukewagner
force-pushed
the
tweak-alignment
branch
from
30a260a to
e9920d7
Compare
Member
Author
|
Updated. So 0 is back to invalid and the parser fills in natural alignment if you leave it off. For testing purposes, explicitly setting |
lukewagner
force-pushed
the
tweak-alignment
branch
from
e9920d7 to
5127a51
Compare
Member
|
lgtm |
Member
|
LGTM, I like this better as well |
lukewagner
added a commit
that referenced
this pull request
Feb 8, 2016
Use 0 instead of None for alignment
ngzhian
pushed a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
…iner Create W3CTAG-SIMDExplainer.md
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
Fixes related .. todo:: section. Addressed review comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that since
0is already an invalid alignment (currently fails the "is a power of 2" check) we don't need alignment to be anint option, we can simply use anint; no reason to have two sentinel cases. This also makes it an epsilon simpler when talking about binary encoding.