Skip to content

Add some more asserts#24

Merged
rossberg merged 1 commit intomasterfrom
assert-more-tests
Aug 25, 2015
Merged

Add some more asserts#24
rossberg merged 1 commit intomasterfrom
assert-more-tests

Conversation

@lukewagner
Copy link
Member

No description provided.

@rossberg
Copy link
Member

LGTM

rossberg added a commit that referenced this pull request Aug 25, 2015
@rossberg rossberg merged commit a3991ca into master Aug 25, 2015
@rossberg rossberg deleted the assert-more-tests branch August 26, 2015 13:15
littledan pushed a commit to littledan/spec that referenced this pull request Mar 4, 2018
See comments in WebAssembly#24:

* Throw an error when constructing shared memory without maximum.
* Lazily create a new SharedArrayBuffer and freeze it after grow.
eqrion pushed a commit to eqrion/wasm-spec that referenced this pull request Sep 18, 2019
alexcrichton pushed a commit to alexcrichton/spec that referenced this pull request Nov 18, 2019
This change adds a variable shuffle instruction to SIMD proposal.

When indices are out of range, the result is specified as 0 for each
lane. This matches hardware behavior on ARM and RISCV architectures.

On x86_64 and MIPS, the hardware provides instructions that can select 0
when the high bit is set to 1 (x86_64) or any of the two high bits are
set to 1 (MIPS). On these architectures, the backend is expected to emit
a pair of instructions, saturating add (saturate(x + (128 - 16)) for
x86_64) and permute, to emulate the proposed behavior.

To distinguish variable shuffles with immediate shuffles, existing
v8x16.shuffle instruction is renamed to v8x16.shuffle2_imm to be
explicit about the fact that it shuffles two vectors with an immediate
argument.

This naming scheme allows for adding variants like v8x16.shuffle2 and
v8x16.shuffle1_imm in the future.

Fixes WebAssembly#68.
Contributes to WebAssembly#24.
Fixes WebAssembly#11.
alexcrichton pushed a commit to alexcrichton/spec that referenced this pull request Nov 19, 2019
Update Explainer strawman text format to conform to Custom Annotation Syntax
ErikMcClure pushed a commit to innative-sdk/spec that referenced this pull request Jun 15, 2020
This also fixes nearby cross-references.

Fixes WebAssembly#24.
dhil added a commit to dhil/webassembly-spec that referenced this pull request Mar 9, 2023
This commit refactors the file `cont.wast` such that it no longer uses
`let` and `func.bind`. We change the type of `spawn` such that it is
parameterised by a continuation type rather than a function type, and
then we replace every use of `func.bind` by a corresponding
`cont.bind`.
backes pushed a commit to backes/spec that referenced this pull request Jul 12, 2023
dhil pushed a commit to dhil/webassembly-spec that referenced this pull request Oct 3, 2023
dhil added a commit to dhil/webassembly-spec that referenced this pull request Feb 12, 2024
rossberg pushed a commit that referenced this pull request Sep 4, 2024
rossberg pushed a commit that referenced this pull request Sep 11, 2025
* Initial commit

* Initial setup and overview

* Update proposal

  * Adopts builtin modules approach
  * Adds section of polyfilling
  * Adds section on feature detection
  * Adds cast/test builtins
  * Adds future extension ideas for
    - binding memory
    - utf8/wtf8
    - evolving the type signatures

* Address review feedback

* Rename concatenate to concat

* Editorial changes

  - Eliminate usage of 'builtin module' in description. This is not essential to the proposal and
    causes confusion around a similarly named JS proposal, which had different goals.
  - Clarify some minor points.
  - Make JS-API changes to WebIDL comprehensive.
  - Reword feature detection section to actually propose change to WebAssembly.validate method

* Tighten up definitions of function builtins

  - Function builtin behaviors is defined using 'create a host function'
  - Clarify behavior around monkey patching using standard language
  - Clarify edge cases around nullability
  - Clarify edge cases around unsigned/signed integers
  - Restrict 'substring' behavior to normal cases
  - Use wasm helpers for when wasm instructions are needed

* Rework support for WTF-8

The existing WTF-8 operation in this proposal violated one of the goals of the
proposal: "don't create substantial new functionality" by introducing WTF-8
transcoding support to the web platform without prior precedent. The WTF-8
operation is removed because of this.

The naming for WTF-16 operations is reworked to refer to 'charCodes' instead
as that is what the JS String interface uses.

We could support UTF-8 transcoding by referring to the TextEncoder/TextDecoder
interfaces, so this commit adds support for that.

* Review comments

* Update substring range checking

* Fix mutability of array i8

Fixes #19.

* Add streaming-related functions

Fixes #19

* Clarify behavior of flags and function names

Fixes #17.

* Fix link to type-imports prposal in js-string-builtins/Overview.md

* Clarify feature detection scheme

Explain that users should validate modules that deliberately produce link errors to test for support for particular builtins.

* Add test for js-string-builtins

This commit adds a basic suite of tests for the js-string-builtins.

This is done by defining a polyfill module matching the overview,
and then comparing the host provided builtins against the polyfill
on representative inputs.

* Fix type signature of 'concat'

Fixes #24.

* Add section on string constants, including Struct.from

* Rework to use imported string constants idea

* Fixup typos

* Add missing start parameter to measureStringAsUTF8 overview

* Update Overview.md

* Many small improvements

- Syntax highlighting
- Added links
- Code font
- Consistency
- Grammer fixes

* Update proposals/js-string-builtins/Overview.md

* Fix nullability for string constants

* Expand section on string constants

* Revert unintentional change to builtins field

* Add note about empty imports object

* Initial outline of builtin support

* Expand specification of builtins

* Remove unneeded modification to embedding spec

* Initial string constants support

* Fix module constructor to handle options

* Don't freeze internal instantiation of builtins and string constants

* Move UTF-8 support to a future proposal

* Remove DS_Store

* Remove DS_Store

* Mark up options appropriately

* Make UnwrapString an abstract-op and use it to implement cast

* Consistently use "steps" instead of "algorithm" for builtins

* Add test

* Add stubs for the rest of the operations

* Add fromCharCode

* Switch to using the Call abstract op, and add fromCodePoint

* Add length

* Add charCodeAt and codePointAt

* Add concat

* Add substring

* Use angle quotes appropriately

* Add basic support for fromCharCodeArray

Needs more detail to properly integrate with GC array ops.

* Make fromCharCodeArray slightly less formal

This avoids having to refer to actual Wasm instructions,
since after all this is a host function.

* Add intoCharCodeArray

* Add equals and compare

* Review fixes for builtin steps

* Tweak wording for trapping in builtins

* Fix spec to separate builtin name used for imports and compile options

* Add note about patching the String builtins

* Add more tests

* Don't validate that every builtin set option is valid

* Fix null-handling for `equals` in test and polyfill

Equals specifically allows null inputs. Update the JS API tests
and the polyfill to match.

* Editorial: replace Type AO with new ECMA-262 type test convention

* actually remove Type

* support per-component polyfill fallbacks

* spec rework

* typo

* Editorial: Align with Web IDL specification

* [js-api] Fix incorrect return statement in 'validate builtin set names'

* [js-api] Remove copy-pasted if statements

* Revert changes to conf and README to prepare for merging

* [tests] Remove tentative from js-string tests

* Expand JS builtin functypes

* Add change history entry

* [js-api] Improve formatting

---------

Co-authored-by: Deepti Gandluri <dtig@users.noreply.github.com>
Co-authored-by: Martin Kustermann <kustermann@google.com>
Co-authored-by: Thomas Lively <tlively@google.com>
Co-authored-by: Ömer Sinan Ağacan <omeragacan@gmail.com>
Co-authored-by: Thomas Steiner <tomac@google.com>
Co-authored-by: Adam Klein <adamk@chromium.org>
Co-authored-by: Michael Ficarra <m.ficarra@f5.com>
Co-authored-by: Guy Bedford <guybedford@gmail.com>
Co-authored-by: autokagami <saschanaz+autokagami@outlook.com>
CharlieTap pushed a commit to CharlieTap/spec that referenced this pull request Sep 25, 2025
…istings

Add Rust toolchain under implementation status
stevenfontanella pushed a commit to stevenfontanella/spec that referenced this pull request Nov 12, 2025
spec:
    WebAssembly@bcb6a41b
  threads:
    WebAssembly/threads@50680261
  simd:
    WebAssembly/simd@68d23f85
  annotations:
    WebAssembly/annotations@318622f0

This change was automatically generated by `update-testsuite.sh`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants