Merged
Conversation
…ve subnormal number.
| "data segment not disjoint and ordered" | ||
| ) | ||
| (assert_invalid | ||
| (module (memory 0 65536)) |
Member
There was a problem hiding this comment.
How about also adding a test with a value that overflows the 32-bit (resp 64-bit range), to check that there is no accidental wrap-around?
Member
|
lgtm |
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
The error messages don't match the tests yet (simd_lane.wast), that still needs to be worked out in WebAssembly#287.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few more floating point tests, but also includes a test for memory size overflow.