Conversation
| ) | ||
|
|
||
| (func "br-bare" (result i32) | ||
| (func "break-bare" (result i32) |
Member
There was a problem hiding this comment.
Please do not rename "br" to "break" in the tests; the instruction is named "br".
Member
Author
There was a problem hiding this comment.
This is to match the loop test cases, where the names distinguish between breaking and continuing (see below). So the naming does not refer to the operator, but to the control flow transfer happening.
Member
There was a problem hiding this comment.
Ok. I guess I'm already in the habit of thinking in terms of WebAssembly/design#652. If we do that, we can simplify these tests.
Member
Author
|
Ping :) |
Member
Author
|
Any opposition to landing these tests? |
Member
|
lgtm |
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This time:
Plus a bug fix in the pretty printer.