Add spec tests for current_memory and grow_memory#317
Closed
d1m0 wants to merge 1 commit intoWebAssembly:masterfrom
Closed
Add spec tests for current_memory and grow_memory#317d1m0 wants to merge 1 commit intoWebAssembly:masterfrom
d1m0 wants to merge 1 commit intoWebAssembly:masterfrom
Conversation
Member
|
Yes, please move these into https://github.com/WebAssembly/spec/pull/316/files#diff-ebd58390f69e54e7cc06428e79f35884 Can you incorporate those as well, in case yours don't cover all of that already? |
Member
|
#316 has landed on the |
Member
|
Binary-0xc has been merged into master. Any interest in updating this PR? |
Member
|
Please also make sure that you're a member of the W3C Community Group. |
rossberg
force-pushed
the
master
branch
2 times, most recently
from
bace049 to
e7632dc
Compare
Member
|
No activity on this for 4 months, closing. |
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
…ts (WebAssembly#317) This is sufficient to pass simd_splat.wast.
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Oct 3, 2023
rossberg
pushed a commit
that referenced
this pull request
Jul 23, 2024
This section is about general exception-related topics, not just tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A more detailed test for the various edge cases of grow memory. checks:
Note that the test currently fails due to incorrect behavior of the ml proto implementation of grow_memory - on failure it returns 0 instead of -1.
Note: This seems to be a superset of tests/resizing.wast. If preferred, I can merge it in that.
Thanks!