Remove obsolete nan-propagation.wast.#321
Conversation
|
Does this require changes to the implementation as well? If so, we should perhaps do them together. In any case, can you please retarget the PR on the binary-0xc branch? |
|
The change landed on master, IIUC. If so, then it's probably best to go On Tue, Aug 23, 2016 at 11:48 AM, rossberg-chromium <
|
|
I see. In that case sgtm, but we should merge to binary-0xc after. @sunfishcode, you probably know best: IIUC the change is purely a relaxation, but is there anything that can/should be simplified in the impl of arithmetics now to reflect it? |
|
This change lgtm.
I've updated #286 with notes about the remaining missing NaN test coverage. |
|
@gahaas, feel free to land this. Bonus points if you also make the simplifications that @sunfishcode mentioned (see |
v8x16.shuffle and v8x16.swizzle is now i8x16.shuffle and i8x16.swizzle respectively. Fixed WebAssembly#316.
The test case was ported from toywasm.
NaN propagation has been removed from the design repo, which made the nan-propagation tests obsolete. this PR removes the nan-propagation tests.