Merged
Conversation
Collaborator
|
Thanks for writing these tests, lgtm |
ngzhian
pushed a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
Opcodes were finalized in WebAssembly#452, this updates the interpreter and spec text to use these final opcodes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #448 it was noticed that the NaN tests for promote and demote tested for a specific bitpattern; they should the new
assert_return_canonical_nan.#414 added several tests using
assert_return_arithmetic_nanto test various operators on signaling NaN. This PR contains a patch which adds such test coverage for more operators.With this last change, f32.wast and f64.wast are growing fairly large, so this PR also contains a patch to split out the bitwise floating-point ops (neg, abs, copysign) into their own file.
And, this adds several other miscellaneous tests.