Closed
Conversation
Fix an error in the custom section lengths, so that the modules are valid except for the particular aspect being tested.
Member
|
Thanks! LGTM (reviewed offline, seems like GitHub can't handle UTF-8). |
Member
|
Argh, sorry I noticed too late that this is a PR against the utf8 branch, which I just landed. So you probably have to merge to master manually. |
Member
Author
|
Github can handle UTF-8, but whoever created those files somehow left invalid byte sequences all over the place ;-). I've now changed the comments to escape those byte sequences, so that the files can be displayed without issue. It looks like I can't change the target branch for this PR, so I'll create a new PR and merge that, with your LGTM here. |
Merged
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Nov 13, 2023
fix display of administrative instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tests to the utf8 branch for validating import module and field names, and custom section names.
This supersedes #450