Merged
Conversation
lukewagner
force-pushed
the
single-return-type
branch
from
f330e59 to
6f15b4a
Compare
lukewagner
force-pushed
the
single-return-type
branch
3 times, most recently
from
40086ab to
1645c20
Compare
lukewagner
force-pushed
the
single-return-type
branch
from
1645c20 to
dc582c3
Compare
Member
Author
|
@rossberg-chromium Thanks! Fixed everything except where prevented by the two issues noteda bove. |
Member
Author
|
Great, agreed and addressed all comments. |
lukewagner
added a commit
that referenced
this pull request
Sep 14, 2015
Remove multiple-return-type support
Member
Author
|
Merging based on LGTM |
ghost
mentioned this pull request
littledan
pushed a commit
to littledan/spec
that referenced
this pull request
Mar 4, 2018
In section "Initializing Memory Only Once" the WebAssembly.instantiate is missing a paren.
eqrion
pushed a commit
to eqrion/wasm-spec
that referenced
this pull request
Sep 18, 2019
…bAssembly#53) * Adjust element segment encoding to match the bulk-memory proposal * Update interpreter/binary/encode.ml Co-Authored-By: Andreas Rossberg <rossberg@mpi-sws.org> * Address comments
alexcrichton
pushed a commit
to alexcrichton/spec
that referenced
this pull request
Nov 18, 2019
rossberg
added a commit
that referenced
this pull request
Jul 3, 2024
Add missing memory specifier to memory.init execution semantics
rossberg
pushed a commit
that referenced
this pull request
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #15, this patch changes expression types from type lists to single types. Since some expressions don't return anything (e.g.,
break),expr_type = value_type option, as suggested in #15.