Conversation
|
First OCaml code ever written so this needs proper review. I've tested the functionality but I am not sure if this is actually a good patch. |
ml-proto/src/arithmetic.ml
Outdated
There was a problem hiding this comment.
== is physical equality in OCaml, you want =. Also, could say i = Int.zero instead, which is shorter.
|
This is cool. Is there a way we can write a test for ctz while adding this code? |
|
@sunfishcode I was hoping (myself soon or others if they go first) to add an "assert" |
|
@eminemix can you please join the WebAssembly Community Group? I can't find your name in the list. This is required for significant contributions to WebAssembly. |
|
Sent v2. @sunfishcode, @lukewagner @jfbastien |
|
Thanks for the patch. Please let me know when you have joined the Community Group, and I will merge your PR. |
Signed-off-by: Valentin Ilie <valentin.ilie@intel.com>
|
This PR cannot be merged due to the issue pointed out by jfbastien. This implementation may appear as part of other PRs where the author complies with the repo guidelines. |
Merge with function-references
Add a references section with useful links
Includes changes for bulk memory instructions and memory abbreviations. See WebAssembly/memory64#5 and WebAssembly/memory64#6.
Teach update-testsuite.sh to look for tests in subdirectories.
Regenerate interpreter with a different extraction of packed stores.
Signed-off-by: Valentin Ilie valentin.ilie@intel.com