Closed
Conversation
Contributor
Honry
commented
Oct 25, 2018
- Add tests to cover accessing table and memory
- Add tests to cover accessing table and memory
Member
|
I believe that the cases you are adding in this PR are already covered extensively by other tests. The respective todos were referring to something else: accessing internally defined tables/memories externally, analogous to the similar tests for for function and global exports that use of "invoke" and "get" actions earlier in this file. However, that would require extending the assertion language with analogous actions on tables and memories, which is why it was left as todos. |
Contributor
Author
@rossberg, thanks for clarification. That is what I was confused on how to accessing tables/memories externally without workarounds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.