Skip to content

[test] Fixed TODO in exports.wast#902

Closed
Honry wants to merge 1 commit intoWebAssembly:masterfrom
Honry:fix-todo-in-exports
Closed

[test] Fixed TODO in exports.wast#902
Honry wants to merge 1 commit intoWebAssembly:masterfrom
Honry:fix-todo-in-exports

Conversation

@Honry
Copy link
Contributor

@Honry Honry commented Oct 25, 2018

  • Add tests to cover accessing table and memory

 - Add tests to cover accessing table and memory
@rossberg
Copy link
Member

I believe that the cases you are adding in this PR are already covered extensively by other tests. The respective todos were referring to something else: accessing internally defined tables/memories externally, analogous to the similar tests for for function and global exports that use of "invoke" and "get" actions earlier in this file. However, that would require extending the assertion language with analogous actions on tables and memories, which is why it was left as todos.

@Honry
Copy link
Contributor Author

Honry commented Oct 29, 2018

that would require extending the assertion language with analogous actions on tables and memories, which is why it was left as todos.

@rossberg, thanks for clarification. That is what I was confused on how to accessing tables/memories externally without workarounds.

@Honry Honry closed this Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants