Remove some archived proposals from this repository#129
Remove some archived proposals from this repository#129alexcrichton merged 1 commit intoWebAssembly:mainfrom
Conversation
This commit removes the test suite mirror for the following proposals: * `exception-handling` * `extended-const` * `function-references` * `gc` * `multi-memory` * `tail-call` These proposals have all been merged into the `wasm-3.0` branch of the specification and their corresponding proposal repositories have all been archived. My assumption is that this means that the source of truth for these specifications now lives in the `wasm-3.0` branch and thus don't need to be doubly-included as those tests are already included.
|
LGTM. Any concerns @titzer? |
|
I'm gonna go ahead and merge this, but happy to revert and/or have follow-ups as necessary. |
|
Hi 👋 ! How the tests are shaped is(often) with most passing tests in a single wasm payload, if that one requires multiple proposals to be available it becomes harder to work iteratively. I see that, in some cases, files has been renamed but left separated (e.g. |
|
This repository is only a reflection of the testsuite in upstream repositories, so questions about naming and test organization is best for the spec/repositories themselves. The repositories removed here have all been archived as their tests are included upstream in the wasm-3.0 branch. Personally I share concerns about how it's difficult to implement a proposal-at-a-time after the fact, but that's something I'd recommend raising on the spec repo rather than here. |
This PR caused the testsuite to fail: WebAssembly/testsuite#129 Meanwhile we find a better solution we can keep working pinning the previous commit.
This commit removes the test suite mirror for the following proposals:
exception-handlingextended-constfunction-referencesgcmulti-memorytail-callThese proposals have all been merged into the
wasm-3.0branch of the specification and their corresponding proposal repositories have all been archived. My assumption is that this means that the source of truth for these specifications now lives in thewasm-3.0branch and thus don't need to be doubly-included as those tests are already included.