Merge upstream spec#207
Merged
conrad-watt merged 26 commits intoWebAssembly:upstream-rebuildfrom Aug 29, 2023
Merged
Conversation
* Add test for the module size limit The limits test did not test the maximum supported module size of 1GB yet. This PR adds tests which create modules consisting of a single custom section. The first test checks if a module of size 1GB is allowed, the second test checks that a module of size 1GB + 1 byte gets rejected. * Some cleanup
* Remove duplicated binary tests Those tests were moved to `binary-leb128.wast` in #1019, but #1287 brought them back. * Remove more duplicated tests
This merges part of WebAssembly/memory64#14 to make the tests fail both before and after memory64. This allows engines to enable memory64 without failing spec tests.
Tests for LEB128 should be in the separate `binary-leb128.wast` test file.
* Allow test for module size limit to fail Allocating a 1GB Uint8Array can fail. In particular, it will always fail on 32-bit systems in V8, where the maximum size of a TypedArray is 2^30-1, thus 1 byte too little.
depended → dependent
…port
Conflicts:
document/core/exec/instructions.rst
- In several places, `:math:`\lanes^{-1}_{\X{i}` was later in the spec changed to `:math:`\lanes^{-1}_{\K{i}`
- Likewise `:math:`\lanes^{-1}_{\iN` was changed to `:math:`\lanes^{-1}_{\IN`.
- Also `:math:`\lanes_{\K{i}N\K{x}` was changed to `:math:`\lanes_{\IN\K{x}` (line 2182 and 2214)
- A forgotten `\V128.\LOAD{N}` was corrected in threads to `\V128\K{.}\LOAD{N}`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conflicts:
document/core/exec/instructions.rst
- In several places,
\lanes^{-1}_{\X{i}was later in the spec changed to\lanes^{-1}_{\K{i}- Likewise
\lanes^{-1}_{\iNwas changed to\lanes^{-1}_{\IN.- Also
\lanes_{\K{i}N\K{x}was changed to\lanes_{\IN\K{x}(line 2182 and 2214)- A forgotten
\V128.\LOAD{N}was corrected in threads to\V128\K{.}\LOAD{N}