[js-api] Add support for resizable ArrayBuffers and growable SharedArrayBuffers#208
Merged
conrad-watt merged 4 commits intoWebAssembly:upstream-rebuildfrom Sep 12, 2023
Merged
Conversation
…dd-RAB-support This adds support for ResizableArrayBuffers and GrowableSharedArrayBuffers, by adding and extending the changes in rab-js-api-integration [1] to include cases for SharedArrayBuffer. Also adds a TODO for the steps of the new HostGrowSharedArrayBuffer algorithm. All this could potentially be refactored to be more concise. [1] WebAssembly/spec#1300
to match the style in the spec PR adding resizable buffers.
…t forget to check these cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for resizable ArrayBuffers and growable SharedArrayBuffers, by adding and extending the changes in rab-js-api-integration [1] to include cases for SharedArrayBuffer.
Also adds a TODO for the steps of the new HostGrowSharedArrayBuffer algorithm.
All this could potentially be refactored to be more concise.
[1] WebAssembly/spec#1300