Merged
Conversation
Contributor
Author
Contributor
Author
|
Not sure if I should also run |
sbc100
approved these changes
Sep 22, 2022
Member
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
lgtm, I think we can worry about any news tests in separate PRs.
Member
|
(Will wait for @keithw approval before landing) |
Member
|
lgtm. An update that runs update-spec-tests.py is at #2001; this brings in the new tokens.wast test, which requires a change to the Wast lexer to get everything passing. |
keithw
approved these changes
Sep 22, 2022
matthias-blume
pushed a commit
to matthias-blume/wabt
that referenced
this pull request
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.