This repository was archived by the owner on Nov 25, 2025. It is now read-only.
Merged
Conversation
Similar to how there exists a `command` world this commit adds a `reactor` world which has everything that a `command` does except for the export of the `run` interface. This mirrors the `preview1-adapter-reactor` that Wasmtime currently has and is intended to make this available for other WIT-based projects as well. This commit additionally refactors the preexisting `command` world to replace all of its `import`s with a single `include` of this new `reactor` world.
pchickey
approved these changes
Sep 8, 2023
Contributor
Author
|
I believe that the CI failure will get fixed by WebAssembly/wasi-tools#18 |
sunfishcode
approved these changes
Sep 12, 2023
alexcrichton
force-pushed
the
reactor
branch
from
22eae24 to
28ccb95
Compare
Contributor
Author
|
Ok I've fixed the CI here by updating to a version of the github action that uses This shouldn't merge until WebAssembly/wit-abi-up-to-date#16 is merged however as otherwise it's pointing at a temporary fork of mine. |
Contributor
Author
|
Ok now I've updated this to the "official" version of the github action so this should be ready to go. |
Member
|
Looks good! |
Mossaka
added a commit
to Mossaka/wasi-cli-fork
that referenced
this pull request
Oct 21, 2023
this PR is a follow up on WebAssembly#23 and simplifies the command world with incldue syntax to hide all the interfaces from deps. Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
sunfishcode
pushed a commit
to Mossaka/wasi-cli-fork
that referenced
this pull request
Nov 15, 2023
this PR is a follow up on WebAssembly#23 and simplifies the command world with incldue syntax to hide all the interfaces from deps. Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to how there exists a
commandworld this commit adds areactorworld which has everything that acommanddoes except for the export of theruninterface. This mirrors thepreview1-adapter-reactorthat Wasmtime currently has and is intended to make this available for other WIT-based projects as well.This commit additionally refactors the preexisting
commandworld to replace all of itsimports with a singleincludeof this newreactorworld.