This repository was archived by the owner on Nov 25, 2025. It is now read-only.
feat(p3): allow trailer retrieval to fail#157
Merged
dicej merged 1 commit intoWebAssembly:mainfrom Mar 12, 2025
Merged
Conversation
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
This was referenced Mar 11, 2025
Member
|
Makes sense to me. |
dicej
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #154
Retrieving trailers implies reading the body of the response, which is a fallible operation.
Currently, guests that call
finishwithout callingstreamfirst have no way to acquire theerror-codethat the operation might have failed with (due to the implicit read of the body). Even in cases where the data frames of the body might have been fully read before callingfinish, reading of the trailers can potentially still fail.