This repository was archived by the owner on Nov 25, 2025. It is now read-only.
fix(p3): allow taking response/request body at most once#159
Closed
rvolosatovs wants to merge 1 commit intoWebAssembly:mainfrom
Closed
fix(p3): allow taking response/request body at most once#159rvolosatovs wants to merge 1 commit intoWebAssembly:mainfrom
rvolosatovs wants to merge 1 commit intoWebAssembly:mainfrom
Conversation
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Member
|
Similar to my reply in #156, the idea is that a request/response can be handed to component A, it can call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #156, specify that the request/response body can be taken only once.
If callers were able to get N references to the body, then they would be able to call
body.finishN times, which would require multiplexing in the host to provide N copies of e.g. the trailers to these N references. It's hard to imagine a use case for this pattern and it also not a common pattern in HTTP libraries as far as I know, so specify that body can only be taken once.