Skip to content
This repository was archived by the owner on Nov 25, 2025. It is now read-only.

fix: rename streams interface#21

Closed
rvolosatovs wants to merge 1 commit intoWebAssembly:mainfrom
rvolosatovs:fix/wasi-streams-import
Closed

fix: rename streams interface#21
rvolosatovs wants to merge 1 commit intoWebAssembly:mainfrom
rvolosatovs:fix/wasi-streams-import

Conversation

@rvolosatovs
Copy link
Contributor

Unfortunately, naming the interface dependency streams causes a clash with wasi_snapshot_preview1.wasm streams causing a runtime panic in wit-component. While the fix for this issue clearly belongs upstream, rename the interface to allow users to utilize the wasi-http interface out-of-the-box already today.

Refs bytecodealliance/wasm-tools#967

You can use https://github.com/rvolosatovs/wasi-http-guest-repro to reproduce the issue and rvolosatovs/wasi-http-guest-repro@96facab to see it fixed by making this change

Unfortunately, naming the interface dependency `streams` causes a clash
with `wasi_snapshot_preview1.wasm` `streams` causing a runtime panic in
`wit-component`. While the fix for this issue clearly belongs upstream,
rename the interface to allow users to utilize the `wasi-http` interface
out-of-the-box already today.

Refs bytecodealliance/wasm-tools#967

Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
@lukewagner
Copy link
Member

I suppose I'd like to wait a bit to see if we can just get the panic fixed upstream before merging anything in the wasi-http repo.

@rvolosatovs rvolosatovs marked this pull request as draft March 31, 2023 18:09
@rvolosatovs rvolosatovs deleted the fix/wasi-streams-import branch April 24, 2023 16:00
@rvolosatovs
Copy link
Contributor Author

This should be fixed by bytecodealliance/wasm-tools#974

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants