Skip to content

[ci] Cancel outstanding workflows when new changes are added to PRs#571

Merged
sbc100 merged 1 commit intoWebAssembly:mainfrom
mcbarton:Don't-allow-more-than-one-ci-run-of-PR-job-at-a-time
Feb 3, 2025
Merged

[ci] Cancel outstanding workflows when new changes are added to PRs#571
sbc100 merged 1 commit intoWebAssembly:mainfrom
mcbarton:Don't-allow-more-than-one-ci-run-of-PR-job-at-a-time

Conversation

@mcbarton
Copy link
Copy Markdown
Contributor

@mcbarton mcbarton commented Feb 3, 2025

If you submit a commit to a PR at the moment and then find an issue with that commit, and submit a new commit to fix the PR before the ci has finished then the ci runs fully for both commits. This PR makes sure that if a new commit is submitted the old ci run is cancelled. This should save on Github runner minutes, ensuring that the slow down across the organisation due to Github runner consumed minutes is less pronounced.

Copy link
Copy Markdown
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this isn't the default!

@sbc100 sbc100 changed the title Don't have more than one ci job running on main or individual PRs at the same time [ci] Cancel outstanding workflows when new changes are added to PRs Feb 3, 2025
@sbc100 sbc100 merged commit 95122c5 into WebAssembly:main Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants